SpotBugs Bug Detector Report
The following document contains the results of SpotBugs
SpotBugs Version is 4.9.8
Threshold is medium
Effort is default
Summary
| Classes |
Bugs |
Errors |
Missing Classes |
| 125 |
19 |
0 |
0 |
com.shortthirdman.primekit.codesignal.MatrixTransformer
| Bug |
Category |
Details |
Line |
Priority |
| Switch statement found in com.shortthirdman.primekit.codesignal.MatrixTransformer.transformMatricesWithCommands(int[][], String[]) where default case is missing |
STYLE |
SF_SWITCH_NO_DEFAULT |
29-69 |
Medium |
com.shortthirdman.primekit.common.Order
| Bug |
Category |
Details |
Line |
Priority |
| com.shortthirdman.primekit.common.Order.items() may expose internal representation by returning Order.items |
MALICIOUS_CODE |
EI_EXPOSE_REP |
6 |
Medium |
| new com.shortthirdman.primekit.common.Order(String, Customer, LocalDate, List, String) may expose internal representation by storing an externally mutable object into Order.items |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
6 |
Medium |
com.shortthirdman.primekit.common.TreeNode
| Bug |
Category |
Details |
Line |
Priority |
| Primitive field com.shortthirdman.primekit.common.TreeNode.left is public and set from inside the class, which makes it too exposed. Consider making it private to limit external accessibility. |
BAD_PRACTICE |
PA_PUBLIC_PRIMITIVE_ATTRIBUTE |
23 |
Medium |
| Primitive field com.shortthirdman.primekit.common.TreeNode.right is public and set from inside the class, which makes it too exposed. Consider making it private to limit external accessibility. |
BAD_PRACTICE |
PA_PUBLIC_PRIMITIVE_ATTRIBUTE |
24 |
Medium |
| Primitive field com.shortthirdman.primekit.common.TreeNode.value is public and set from inside the class, which makes it too exposed. Consider making it private to limit external accessibility. |
BAD_PRACTICE |
PA_PUBLIC_PRIMITIVE_ATTRIBUTE |
18 |
Medium |
com.shortthirdman.primekit.core.agents.Action
| Bug |
Category |
Details |
Line |
Priority |
| com.shortthirdman.primekit.core.agents.Action.effects() may expose internal representation by returning Action.effects |
MALICIOUS_CODE |
EI_EXPOSE_REP |
13 |
Medium |
| com.shortthirdman.primekit.core.agents.Action.preconditions() may expose internal representation by returning Action.preconditions |
MALICIOUS_CODE |
EI_EXPOSE_REP |
13 |
Medium |
| new com.shortthirdman.primekit.core.agents.Action(String, Map, Map, double) may expose internal representation by storing an externally mutable object into Action.effects |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
13 |
Medium |
| new com.shortthirdman.primekit.core.agents.Action(String, Map, Map, double) may expose internal representation by storing an externally mutable object into Action.preconditions |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
13 |
Medium |
com.shortthirdman.primekit.core.agents.Plan
| Bug |
Category |
Details |
Line |
Priority |
| com.shortthirdman.primekit.core.agents.Plan.actions() may expose internal representation by returning Plan.actions |
MALICIOUS_CODE |
EI_EXPOSE_REP |
12 |
Medium |
| new com.shortthirdman.primekit.core.agents.Plan(List, double) may expose internal representation by storing an externally mutable object into Plan.actions |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
12 |
Medium |
com.shortthirdman.primekit.hackerearth.ListNodeOps
| Bug |
Category |
Details |
Line |
Priority |
com.shortthirdman.primekit.hackerrank.CompWinnerEvaluator
| Bug |
Category |
Details |
Line |
Priority |
| Switch statement found in com.shortthirdman.primekit.hackerrank.CompWinnerEvaluator.evaluateWinner(String, String) where default case is missing |
STYLE |
SF_SWITCH_NO_DEFAULT |
24-32 |
Medium |
com.shortthirdman.primekit.hackerrank.ReversePolishNotation
| Bug |
Category |
Details |
Line |
Priority |
| Switch statement found in com.shortthirdman.primekit.hackerrank.ReversePolishNotation.evaluateRPN(String[]) where default case is missing |
STYLE |
SF_SWITCH_NO_DEFAULT |
25-36 |
Medium |
com.shortthirdman.primekit.hackerrank.TradingProfitCalculator
| Bug |
Category |
Details |
Line |
Priority |
| com.shortthirdman.primekit.hackerrank.TradingProfitCalculator.getNetProfit(List) makes inefficient use of keySet iterator instead of entrySet iterator |
PERFORMANCE |
WMI_WRONG_MAP_ITERATOR |
105 |
Medium |
com.shortthirdman.primekit.leetcode.CheapestFlightsKStops
| Bug |
Category |
Details |
Line |
Priority |
| com.shortthirdman.primekit.leetcode.CheapestFlightsKStops.findCheapestPrice(int, int[][], int, int, int) makes inefficient use of keySet iterator instead of entrySet iterator |
PERFORMANCE |
WMI_WRONG_MAP_ITERATOR |
55 |
Medium |
com.shortthirdman.primekit.leetcode.RussianDollEnvelopes
| Bug |
Category |
Details |
Line |
Priority |
| Computation of average could overflow in com.shortthirdman.primekit.leetcode.RussianDollEnvelopes.lengthOfLIS(int[]) |
STYLE |
IM_AVERAGE_COMPUTATION_COULD_OVERFLOW |
83 |
Medium |
com.shortthirdman.primekit.leetcode.WiggleSort
| Bug |
Category |
Details |
Line |
Priority |
| Check for oddness that won't work for negative numbers in com.shortthirdman.primekit.leetcode.WiggleSort.wiggleSort(int[]) |
STYLE |
IM_BAD_CHECK_FOR_ODD |
15 |
Medium |
